feat(docs): enhance DocumentationMenuItem validation and file checks#3044
Closed
monayemislam wants to merge 6 commits intorectorphp:mainfrom
Closed
feat(docs): enhance DocumentationMenuItem validation and file checks#3044monayemislam wants to merge 6 commits intorectorphp:mainfrom
monayemislam wants to merge 6 commits intorectorphp:mainfrom
Conversation
TomasVotruba
reviewed
Dec 7, 2025
Member
|
Thanks 👍 I've approved CI to see how it runs. Tests needs fix now. |
Author
|
Okay. I am on it. |
Member
|
@monayemislam you need to rebase latest main of this repo to make test green |
…dded parameter descriptions for constructor, enforced href and label non-emptiness, and introduced hasDocumentation method to check file existence.
…prove readability
Author
|
@samsonasik I rebase it. But still not passing the unit test. Can you let me know why? |
Member
|
You seems change FixtureLinkFactory Which cause the test error, revert unrelated change :) |
…g and improve readability" This reverts commit 0cc7644.
Member
|
Tests are still failing. From hindsight, this makes code much more verbose and hard to read, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance
DocumentationMenuItemclass with validation and new method. Added parameter descriptions for constructor, enforcedhrefand label non-emptiness, and introducedhasDocumentationmethod to check file existence.